>>>>> "Eric" == Eric Botcazou <ebotca...@adacore.com> writes:
Pedro> It's not about example, but the fact that host compilers have been Pedro> compiling that code as part of building gcc for years, without anyone Pedro> complaining, afaik. It doesn't matter whether the code pointed at Pedro> is the ugliest or most beautiful code on earth. What matters is whether Pedro> it uses long long unconditionally on all hosts or not. Pedro> IOW, what are the still supported hosts/compilers that don't Pedro> support "long long"? If there are any, it appears none has been used Pedro> in at least the past 5 years, IIU the code correctly. Eric> OK, but GCC still officially requires only an ISO C90 compiler Eric> http://gcc.gnu.org/install/prerequisites.html Eric> so the usage of 'long long' in libdecnumber is a bug that could be Eric> fixed at some point. That's why using it as a precedent isn't the Eric> best thing to do. It's true that this is a pedantic violation; but the point here is that there is no practical barrier to using 'long long'. This code has been in the tree since 2007; so if there is some issue with it, it ought to have surfaced by now. Tom
