On Wed, May 15, 2024 at 3:05 PM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 5/15/24 12:48 AM, Christoph Müllner wrote: > > Emitting a DI pattern won't find a match for rv32 and manifests in > > the failing test case gcc.target/riscv/cmo-zicboz-zic64-1.c. > > Let's fix this in the expansion and also address the different > > code that gets generated for rv32/rv64. > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-string.cc > > (riscv_expand_block_clear_zicboz_zic64b): > > Fix expansion for rv32. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/cmo-zicboz-zic64-1.c: Fix for rv32. > The exact change I made yesterday for the code generator. Glad to see I > didn't muck it up :-) And thanks for fixing the test to have some > coverage on rv32.
I prepared this patch a few weeks ago. And I was convinced that I did a multilib-test back then (as I usually do), so I just rebased and executed the rv64 tests before sending them last week. I was quite surprised to find this failing while working on the cmpmem expansion, since this was still in my queue to rebase/retest. Whatever, sorry for not testing earlier and thanks for fixing it!
