On Tue, Jun 12, 2012 at 6:57 PM, Diego Novillo <dnovi...@google.com> wrote:
> On 12-06-08 22:25 , Sandeep Soni wrote:
>>
>> Hi,
>>
>> This patch fixes the failure test case that I had submitted the last time.
>>
>> The changeLog is testsuite/gChangeLog.gimplefe is as follows.
>>
>> 2012-06-09 Sandeep Soni<soni.sande...@gmail.com>
>> * gimple.dg/20120605-2.gimple : New.
>>
>> While the changelog in gimple/ChangeLog is as follows
>> 2012-06-09 Sandeep Soni<soni.sande...@gmail.com>
>> * parser.c (gp_parse_expect_return_var) : Modify to have
>> correct token consumption.
>
>
> I don't follow how your patch fixes the ICE. Could you describe it a bit
> more? How was it failing?
>
One of the previous versions of the code in gp_parse_call_stmt relied
on gimple_peek_token. But in some subsequent patch that was replaced
with gimple_consume_token in order to avoid excessive peeking. This
caused breaking of the compiler because it consumed more tokens than
required and was left to expect more tokens.
The patch fixes that.
> You'll need a blank line after the date line in ChangeLog entries.
>
Here is the modified ChangeLog entry
2012-06-09 Sandeep Soni<soni.sande...@gmail.com>
* gimple.dg/20120605-2.gimple : New.
While the changelog in gimple/ChangeLog is as follows
2012-06-09 Sandeep Soni<soni.sande...@gmail.com>
* parser.c (gp_parse_expect_return_var) : Modify to have
correct token consumption.
--
Cheers
Sandy
