On 4/30/24 8:43 AM, Gaius Mulley wrote:
> Christophe Lyon <christophe.l...@linaro.org> writes:
>
>> On Tue, 30 Apr 2024 at 04:01, Simon Marchi <simon.mar...@polymtl.ca> wrote:
>>>
>>> I get a diff when running "autoreconf" in this directory. I think that
>>> the current state is erroneous: it appears to have been generated using
>>>
>>> aclocal -I ../config -I ..
>>>
>>> even though configure.ac and Makefile.am list the include flag in the
>>> reverse order:
>>>
>>> aclocal -I .. -I ../config
>>>
>>> Running "autoreconf" uses the latter order, so I think that's the
>>> "right" output.
>>>
>>> No functional difference expected.
>>
>> Thanks, this matches what I noticed.
>> I'm not a maintainer, so I cannot approve, but a minor remark: in GCC
>> we still need a ChangeLog entry in the commit message.
>>
>> Christophe
>
> many thanks for spotting this bug, lgtm,
>
> regards,
> Gaius
Here is the ChangeLog entry:
libgm2/ChangeLog:
* Makefile.in, aclocal.m4, libm2cor/Makefile.in,
libm2iso/Makefile.in, libm2log/Makefile.in,
libm2min/Makefile.in, libm2pim/Makefile.in: Re-generate.
I don't have access to the gcc repo, so could you please push the patch
on my behalf?
Thanks,
Simon
