On Thu, Apr 4, 2024 at 5:34 PM <rep.dot....@gmail.com> wrote: > > On 3 April 2024 15:49:13 CEST, "H.J. Lu" <hjl.to...@gmail.com> wrote: > > > >> OK witht that change. > >> Honza > > > >I am checking in this patch with the updated comments: > > > > /* Disable indirect call profiling for an IFUNC resolver and its > > callees since it requires TLS which hasn't been set up yet when > > the dynamic linker is resolving IFUNC symbols. See > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114115 > > */ > > > >Thanks. > > > > + /* Skip if it has been visited. */ > + unsigned int uid = e->caller->get_uid (); > + if (bitmap_bit_p (ifunc_ref_map, uid)) > + continue; > + bitmap_set_bit (ifunc_ref_map, uid); > > I think you could have written this as > if (!bitmap_set_bit (ifunc_ref_map, uid)) > continue; >
Feel free to submit a patch. Thanks. -- H.J.
