On Fri, 22 Mar 2024, Jakub Jelinek wrote: > Hi! > > I've noticed that the c-c++-common/gomp/depobj-3.c test FAILs on i686-linux: > PASS: c-c++-common/gomp/depobj-3.c -std=c++17 at line 17 (test for > warnings, line 15) > FAIL: c-c++-common/gomp/depobj-3.c -std=c++17 at line 39 (test for > warnings, line 37) > PASS: c-c++-common/gomp/depobj-3.c -std=c++17 at line 43 (test for errors, > line 41) > PASS: c-c++-common/gomp/depobj-3.c -std=c++17 (test for warnings, line 45) > FAIL: c-c++-common/gomp/depobj-3.c -std=c++17 (test for excess errors) > Excess errors: > /home/jakub/src/gcc/gcc/testsuite/c-c++-common/gomp/depobj-3.c:37:38: > warning: the 'destroy' expression ''excess_precision_expr' not supported by > dump_expr<expression error>' should be the same as the 'depobj' argument > 'obj' [-Wopenmp] > The following patch replaces that 'excess_precision_expr' not supported by > dump_expr<expression error> > with (float)(((long double)a) + (long double)5) > Still ugly and doesn't actually fix the FAIL (will deal with that > incrementally), but at least valid C/C++ and shows the excess precision > handling in action. > > Ok for trunk if this passes bootstrap/regtest? > > 2024-03-22 Jakub Jelinek <ja...@redhat.com> > > gcc/c/ > * c-pretty-print.cc (pp_c_cast_expression, > c_pretty_printer::expression): Handle EXCESS_PRECISION_EXPR like > NOP_EXPR.
The c-pretty-print.cc changes are OK. -- Joseph S. Myers josmy...@redhat.com