On 06/01/2012 01:58 PM, Sterling Augustine wrote:
It also adds and documents a new option "-g[no-]pubtypes" which allows users
to generate pubtypes even if the target disables them by default.
Hmm, I thought the convention for this sort of flag was to start with
-f, that -g flags were only for selecting the type and level of debug
info. But I see that there are other debug dialect switches that use
-g, so I guess this is OK.
+ if ((TREE_PUBLIC (decl) && !is_class_die (die->die_parent))
Why not include public class members? Is the theory that you'll need to
read the type DIE anyway to do anything with the member, so you might as
well read it to look up the member in the first place? There should be
a comment about this.
+ VEC_safe_push (pubname_entry, gc, pubtype_table, &e);
Why add enumerators to pubtypes rather than pubnames? They seem more
like variables than types to me.
+ here. This isn't protected by the name conditional because anoymous
Missing an 'n' in "anonymous".
A C++ opaque enumeration is considered complete, but does not yet have
its enumerators, which can be added later. Does this code handle that?
+ if (use_debug_types && names == pubtype_table)
This should check pub->die->comdat_type_p
Jason
