Hi YunQiang Su, On Fri, Mar 15, 2024 at 03:33:28PM +0800, YunQiang Su wrote: > Great work. The CI works well now: it blames me ;) > https://builder.sourceware.org/buildbot/#/builders/269/builds/3846 > > When I add '-mstrict-align' option to MIPS, > the riscv.opt.urls, sysv4.opt.urls, xtensa.opt.urls are changed also. > (why they are effected?
They are effected because they also have a '-mstrict-align' option and each option with the same name gets an unique number. > So what's the best practice for this cases? > Should I push a new commit? Or in fact a single commit is preferred? I don't know if there is a rule for this. But I hope this falls under the obvious rule. What I would do is simply take that diff the CI produced. https://builder.sourceware.org/buildbot/api/v2/logs/7798308/raw Apply it and commit that with: Regenerate opt.urls Fixes: acc38ff59976 ("MIPS: Add -m(no-)strict-align option") gcc/ChangeLog: * config/riscv/riscv.opt.urls: Regenerated. * config/rs6000/sysv4.opt.urls: Likewise. * config/xtensa/xtensa.opt.urls: Likewise. Cheers, Mark
