On Fri, Feb 23, 2024 at 3:48 AM Palmer Dabbelt <pal...@dabbelt.com> wrote: > > On Wed, 21 Feb 2024 16:02:50 PST (-0800), Kito Cheng wrote: > > Palmer Dabbelt <pal...@dabbelt.com> 於 2024年2月22日 週四 07:42 寫道： > > > >> On Wed, 21 Feb 2024 15:34:32 PST (-0800), Kito Cheng wrote: > >> > LGTM for the patch > >> > > >> > Li, Pan2 <pan2...@intel.com> 於 2024年2月21日 週三 12:31 寫道： > >> > > >> >> Hi kito and juzhe. > >> >> > >> >> There may be 2 items for double-confirm. Thanks a lot. > >> >> > >> >> 1. Not very sure if we need to upgrade the version for > >> >> __riscv_th_v_intrinsic. > >> >> > >> > > >> > Yes since 0.11 and 0.12 is not really compatible > >> > >> Where are the incompatibilities? The whole reason we accepted the > >> intrinsics in the first place is because the RVI folks said they > >> wouldn't break compatibility, if that's changed then just dropping the > >> old version is going to break users. > >> > > > > 0.12 have interface for segment load store and new fixed points intrinsic > > compare to 0.11, the first one item is not incompatible change since it's > > new added and gcc 13 isn't implemented the legacy one, the later one is > > kinda broken on both llvm and gcc which is made is not really useful in > > practice. > > > > Other than that, everything are same, it's not 100% compatible so I am not > > intend to cheating my self to say it's compatible, but we do think it's > > necessary evil since fixing point stuff are not right design and > > implementation. > > OK, those don't seem so scary. So maybe let's just put it in a NEWS > entry or something? It's mildly interesting to users, but I agree the > earlier intrinsics spec was vague enough in some areas we can get away > with the diffs I've seen.
Yeah, thanks for the reminder, I guess we need to prepare to update more NEWS entries... > > > Anyway it's became frozen mode, 1.0 rc0 has been tagged, no API will > > change/remove. > > OK, so I guess we should move to 1.0, then? Are you guys going to pick > that up? No difference between 0.12 and 1.0...here is just some paperwork for the process that is still ongoing...but anyway we will handle that.
