On Fri, May 18, 2012 at 5:05 PM, Eric Botcazou <ebotca...@adacore.com> wrote:

>        * configure.ac (HAVE_GNU_LD): Move to after config.gcc inclusion.
>        (HAVE_GNU_AS): Likewise.
>        * config.in: Regenerate.
>        * configure: Likewise.

Eric,

This change is breaking bootstraps in one of the google branches
because it does not allow us to control the presence of GNU as with
the --with-gnu-as= configure flag.

When doing native bootstraps, we need to set --with-gnu-as=no because
binutils 'as' does not handle a flag that we pass to our own version
of 'as'.

This is a combination of problems, actually:

1- The local patch we have that enables the new flag is keyed on
HAVE_GNU_AS.  Easwaran, I think this is a patch of yours from Apr
2011:

2011-04-20  Easwaran Raman  <era...@google.com>

        * gcc.c (asm_options): Pass --save-temps to assembler.

The change should not assume that HAVE_GNU_AS means that we can use
--save-temps.  You should use a new configuration flag for it.


2- Eric, your patch essentially disables the --with-gnu-as= flag.
When doing a native bootstrap on the 4.7 branch, HAVE_GNU_AS is set to
1, regardless of the value of --with-gnu-as.  The problem is that your
new test to decide whether to use gas just uses the value set in
config.gcc.

Easwaran, I will revert Eric's patch from our 4.7 branch.

Eric, shouldn't the whole section testing for GNU as move after the
inclusion of config.gcc?


Thanks.  Diego.

Reply via email to