Hi,

Il giorno 05/giu/2012, alle ore 16:16, Jason Merrill <ja...@redhat.com> ha 
scritto:

> On 06/05/2012 07:00 AM, Paolo Carlini wrote:
>>    (construct_virtual_base): Adjust LOOKUP_COMPLAIN ->  LOOKUP_NORMAL.
> 
> This and the similar changes elsewhere seem dangerous; they're adding adding 
> LOOKUP_PROTECT that wasn't there before.  Instead, let's replace 
> LOOKUP_COMPLAIN with 0 or some macro defined to 0.

Indeed, sorry about that, somehow I got confused.

> I would also keep the LOOKUP_PROTECT macro rather than replace its uses with 
> LOOKUP_NORMAL.

To be sure: NORMAL used to be just PROTECT | COMPLAIN, thus it's just about 
names, right? You mean, we do away with the NORMAL name, you mean? (indeed I 
had a moment of esitation about this, when I noticed that the comment preceding 
now NORMAL is the one which used to preceed PROTECT)
> 


I'll send an updated patch later today.

Thanks!
Paolo

Reply via email to