On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher <stevenb....@gmail.com> wrote: > Hello, > > The attached patch removes one more #include output.h, this time from > c-family/c-pch.c. > > Anything written out to asm_out_file between pch_init and > c_common_write_pch is read back in by c_common_write_pch and dumped to > the PCH that's being written out. In c_common_read_pch this data is > written out verbatim to asm_out_file again. > > But nothing should write to asm_out_file between pch_init and > c_common_write_pch. I suppose this happened before unit-at-a-time > became the only supported compilation mode, but these days there's > nothing, AFAICT, that should be written to asm_out_file by a front end > during PCH generation. > > This patch was bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for > trunk?
I think the patch is reasonable but I'll defer to Joseph for approval. Out of curiosity - what about that #ident thing? I suppose we'd ICE until you have fixed that part, no? Thanks, Richard. > Ciao! > Steven
