On 06/01/2012 03:55 PM, Florian Weimer wrote:
On 06/01/2012 06:19 PM, Jason Merrill wrote:
On 06/01/2012 11:40 AM, Florian Weimer wrote:
I'm puzzled why build_new is even invoked after detecting that there is
a non-constant expression.
I'd accept a patch to change that.
I don't really now what I'm doing here. But I noticed that in
cp_parser_constant_expression, a failure in
require_potential_rvalue_constant_expression is not reported to the caller.
This changes error reporting, and a few test cases need adjustment. In
some, reporting is better, in others, it's slightly worse. I need to
make a second pass over the changes to make sure that they are alright.
Oh, right. I think I tried this change once and then decided that
things were better without it, but I don't remember why. The change
looks reasonable by itself; what changes are you seeing in error reporting.
Jason
