> -----Original Message-----
> From: Torbjorn SVENSSON <torbjorn.svens...@foss.st.com>
> Sent: Wednesday, February 7, 2024 8:23 AM
> To: Andrew Pinski (QUIC) <quic_apin...@quicinc.com>; gcc-
> patc...@gcc.gnu.org
> Cc: Yvan Roux <yvan.r...@foss.st.com>
> Subject: Re: [PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain
> char is unsigned by default
>
> Hi,
>
> Is it okay to backport 6e15e4e1abed02443a27a69455f4bfa49457c99e to
> releases/gcc-13?
From my point of view, this is ok to backport. It is just a testsuite change so
I didn't think it was important enough to backport from an user of GCC point of
view.
Thanks,
Andrew Pinski
>
> Without this backport, I see this failure on arm-none-eabi:
>
> FAIL: g++.dg/contracts/contracts-tmpl-spec2.C output pattern test
>
> Kind regards,
> Torbjörn
>
>
> On 2023-11-26 03:57, Andrew Pinski wrote:
> > Since contracts-tmpl-spec2.C is just testing contracts, I thought it
> > would be better to just add `-fsigned-char` to the options rather than
> > change the testcase to support both cases.
> >
> > Committed after testing on aarch64-linux-gnu.
> >
> > gcc/testsuite/ChangeLog:
> >
> > PR testsuite/108321
> > * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
> > to options.
> > ---
> > gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > index 82117671b2d..fd3a25bd051 100644
> > --- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > +++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
> > @@ -1,6 +1,6 @@
> > // basic test to ensure contracts work for class and member
> > specializations
> > // { dg-do run }
> > -// { dg-options "-std=c++2a -fcontracts
> > -fcontract-continuation-mode=on" }
> > +// { dg-options "-std=c++2a -fcontracts
> > +-fcontract-continuation-mode=on -fsigned-char" }
> > #include <cstdio>
> >
> > // template specializations can have differing contracts
