Hi All,

With recent updates to hwasan runtime libraries, the error reporting for
this particular check is has been reworked.

I would question why it has lost this message.  To me it looks strange
that num_descriptions_printed is incremented whenever we call
PrintHeapOrGlobalCandidate whether that function prints anything or not.
(See PrintAddressDescription in libsanitizer/hwasan/hwasan_report.cpp).

The message is no longer printed because we increment this
num_descriptions_printed variable indicating that we have found some
description.

I would like to question this upstream, but it doesn't look that much of
a problem and if pressed for time we should just change our testsuite.
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.

Ok for master?

Thanks,
Tamar

gcc/testsuite/ChangeLog:

        PR sanitizer/112644
        * c-c++-common/hwasan/hwasan-thread-clears-stack.c: Update testcase.

--- inline copy of patch -- 
diff --git a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c 
b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
index 
09c72a56f0f50a8c301d89217aa8c7df70087e6c..6c70684d72a887c49b02ecb17ca097da81a9168f
 100644
--- a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
+++ b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
@@ -52,5 +52,4 @@ main (int argc, char **argv)
 
 /* { dg-output "HWAddressSanitizer: tag-mismatch on address 0x\[0-9a-f\]*.*" } 
*/
 /* { dg-output "READ of size 4 at 0x\[0-9a-f\]* tags: 
\[\[:xdigit:\]\]\[\[:xdigit:\]\]/00 \\(ptr/mem\\) in thread T0.*" } */
-/* { dg-output "HWAddressSanitizer can not describe address in more 
detail\..*" } */
 /* { dg-output "SUMMARY: HWAddressSanitizer: tag-mismatch \[^\n\]*.*" } */




-- 
diff --git a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c 
b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
index 
09c72a56f0f50a8c301d89217aa8c7df70087e6c..6c70684d72a887c49b02ecb17ca097da81a9168f
 100644
--- a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
+++ b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
@@ -52,5 +52,4 @@ main (int argc, char **argv)
 
 /* { dg-output "HWAddressSanitizer: tag-mismatch on address 0x\[0-9a-f\]*.*" } 
*/
 /* { dg-output "READ of size 4 at 0x\[0-9a-f\]* tags: 
\[\[:xdigit:\]\]\[\[:xdigit:\]\]/00 \\(ptr/mem\\) in thread T0.*" } */
-/* { dg-output "HWAddressSanitizer can not describe address in more 
detail\..*" } */
 /* { dg-output "SUMMARY: HWAddressSanitizer: tag-mismatch \[^\n\]*.*" } */



Reply via email to