Re: [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061)

[asharif]

Reviewers: xur, davidxl, iant2, Diego Novillo,

Message:
The relevant bug is this:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.

Please take a look and provide feedback.

Thanks,

Description:
2012-05-31   Ahmad Sharif  <asha...@google.com>

        * gcc/dwarf2asm.c: (dw2_output_indirect_constant_1): Copy TREE_STATIC()
        attribute from id to decl.

Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c     (revision 188089)
+++ gcc/dwarf2asm.c     (working copy)
@@ -907,6 +907,7 @@
   DECL_IGNORED_P (decl) = 1;
   DECL_INITIAL (decl) = decl;
   TREE_READONLY (decl) = 1;
+  TREE_STATIC (decl) = TREE_STATIC (id);

   if (TREE_PUBLIC (id))
     {
@@ -915,8 +916,6 @@
       if (USE_LINKONCE_INDIRECT)
        DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
     }
-  else
-    TREE_STATIC (decl) = 1;

   sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
   assemble_variable (decl, 1, 1, 1);


Please review this at http://codereview.appspot.com/6133061/

Affected files:
  M     gcc/dwarf2asm.c


2012-04-30   Ahmad Sharif  <asha...@google.com>

        * gcc/dwarf2asm.c: copy TREE_STATIC() property from id.

Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c     (revision 186998)
+++ gcc/dwarf2asm.c     (working copy)
@@ -907,6 +907,7 @@
   DECL_IGNORED_P (decl) = 1;
   DECL_INITIAL (decl) = decl;
   TREE_READONLY (decl) = 1;
+  TREE_STATIC (decl) = TREE_STATIC (id);

   if (TREE_PUBLIC (id))
     {
@@ -915,8 +916,6 @@
       if (USE_LINKONCE_INDIRECT)
        DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
     }
-  else
-    TREE_STATIC (decl) = 1;

   sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
   assemble_variable (decl, 1, 1, 1);