On Mon, Jan 08, 2024 at 10:22:57AM +0100, Ilya Leoshkevich wrote:
> Bootstrap and regtest running on x86_64-redhat-linux,
> ppc64le-redhat-linux and s390x-redhat-linux.  Ok for trunk when
> successful?
> 
> 
> 
> Using ASAN on i686-linux with -fPIC causes an ICE, because when
> pc_thunks are generated, there is no current function anymore, but
> asan_function_start () expects one.
> 
> Fix by not calling asan_function_start () without one.
> 
> A narrower fix would be to temporarily disable ASAN around pc_thunk
> generation.  However, the issue looks generic enough, and may affect
> less often tested configurations, so go for a broader fix.
> 
> Fixes: e66dc37b299c ("asan: Align .LASANPC on function boundary")
> Suggested-by: Jakub Jelinek <ja...@redhat.com>
> Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com>
> 
> gcc/ChangeLog:
> 
>       PR sanitizer/113251
>       * varasm.cc (assemble_function_label_raw): Do not call
>       asan_function_start () without the current function.

LGTM, thanks.

        Jakub

Reply via email to