Hi Joseph,
Thanks for the review!
On 12/18/23 20:00, Joseph Myers wrote:
On Fri, 8 Sep 2023, Arthur Cohen wrote:
+ if (c < 0x80)
+ {
+ if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z'))
+ return CPP_XID_START | CPP_XID_CONTINUE;
+ if (('0' <= c && c <= '9') || c == '_')
+ return CPP_XID_CONTINUE;
This may be an artifact of how the patch was mailed, but indentation seems
off here (should be six spaces for both return statements) >
+ md = (mn + mx) / 2;
+ if (c <= ucnranges[md].end)
+ mx = md;
+ else
+ mn = md + 1;
And likewise here (should be a tab for both assignments).
OK with those indentation fixes.
Thanks for noticing - this was indeed misindented.
I'll make the suggested fixes and will push the patch.
Best,
Arthur
