Oh, I see. Thanks Jeff for suggestion, will refine the commit log in V2. Pan
-----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Wednesday, December 20, 2023 12:03 PM To: juzhe.zh...@rivai.ai; Li, Pan2 <pan2...@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org> Cc: Wang, Yanzhang <yanzhang.w...@intel.com>; kito.cheng <kito.ch...@gmail.com> Subject: Re: [PATCH v1] RISC-V: Bugfix for the const vector in single steps On 12/19/23 19:50, juzhe.zh...@rivai.ai wrote: > > + if (known_eq (ele_0 - 0, ele_n - v.npatterns ())) > > > -> > > for (i = 0; i < v.npatterns (); ) > check each nelt of npatterns is equal to vid. Pan -- please indicate what testing was performed. The standard is to test with and without the patch to verify there are no regressions. You don't have to test every multilib or anything like that. Just pick a configuration and test it. No patch should be committed to the tree without this basic information. We've been lax on that policy, but that really needs to change. jeff
