Hi Arthur, Pierre-Emmanuel! On 2023-11-27T16:46:08+0100, I wrote: > On 2023-11-21T16:20:22+0100, Arthur Cohen <arthur.co...@embecosm.com> wrote: >> On 11/20/23 15:55, Thomas Schwinge wrote: >>> Arthur and Pierre-Emmanuel have prepared a GCC/Rust libgrust-v2/to-submit >>> branch: <https://github.com/Rust-GCC/gccrs/tree/libgrust-v2/to-submit>.
..., and now updated once again. >>> In that one, most of the issues raised have been addressed, and which >>> I've now successfully "tested" in my different GCC configurations, >>> requiring just one additional change (see end of this email). I'm using >>> "tested" in quotes here, as libgrust currently is still missing its >>> eventual content, and still is without actual users, so we may still be >>> up for surprises later on. ;-) >>> Then, still should re-order the commits [...] > So I suggest: > > - "libgrust: Add entry for maintainers and stub changelog file" > - "libgrust: Add libproc_macro and build system" > ... plus 'autoreconf' in 'libgrust/' folded in. > ... plus 'contrib/gcc_update' update moved here. > - "build: Add libgrust as compilation modules" > ... plus "Disable target libgrust if missing libstdc++" folded in. > ... plus 'autoreconf' and 'autogen'in '/' folded in. > - "Regenerate build files" then evaporates. That's now been done, thanks. Rebasing onto current master branch, there's a minor (textual) conflict in top-level 'configure.ac:host_libs': 'intl' replaced by 'gettext', and top-level 'configure' plus 'gcc/configure' have to be re-generated (the latter for some unrelated changes in line numbers). Otherwise, those initial libgrust changes are now in the form that I thought they should be in -- so I suggest you fix that up (I can quickly have a look again, if you like), and then you do the "scary" 'git push' ;-) -- and then: >> All the best, and thanks again for testing :) > > :-) So I hope I've not missed any major issues... ..., we wait and see. :-) Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
