On Fri, Dec 08, 2023 at 04:49:49PM +0300, Alexander Monakov wrote:
> I would like to propose Valgrind integration previously sent as RFC for trunk.
>
> Arsen and Sam, since you commented on the RFC I wonder if you can have
> a look at the proposed configure and documentation changes and let me
> know if they look fine for you? For reference, gccinstall.info will say:
Does VALGRIND_MAKE_MEM_UNDEFINED macro ever change onarches once implemented
there? Wouldn't this be better done by emitting the sequence inline?
Even if it is done in libgcc, it is part of ABI.
So, basically add a new optab, valgrind_request, where each target would
define_insn whatever is needed (it will need to be a single pattern, it
can't be split among multiple) and sorry on -fvalgrind-annotations if the
optab is not defined.
Advantage would be that --enable-valgrind-interop nor building against
valgrind headers is not needed.
In your version, did the new function go just to libgcc.a or to
libgcc_s.so.1? Having a function in there or not dependent on
--enable-valgrind-interop would turn it into an ABI configure option.
Jakub
