On 11/28/23 11:51, Patrick Palka wrote:
Bootstrapped and regtested on x86-64-pc-linux-gnu, does this look OK for
trunk?
-- >8 --
Here we deem the array-to-pointer conversions in both calls as invalid,
but we fail to issue a diagnostic for the second call, ultimately because
cp_build_c_cast doesn't replay errors from build_const_cast_1. This means
the second call get silently discarded leading to wrong/unexpected code.
This patch fixes this issue. I'm not sure if we want to accept these
conversions in the first place (that's PR94264 or at least related to
it), but at least we're more consistent now.
I've now fixed that bug, thanks for the pointer.
The cp_build_c_cast change is OK, but the testcase won't error anymore.
Do you have an idea for an alternate test? If not, it's OK to apply the
fix anyway.
Jason
