On Fri, Nov 10, 2023 at 06:03:40PM -0600, Peter Bergner wrote: > On 8/25/23 6:20 AM, Kewen.Lin wrote: > > btw, I was also expecting that we don't implicitly set > > OPTION_MASK_PCREL any more for Power10, that is to remove > > OPTION_MASK_PCREL from OTHER_POWER10_MASKS. > > So my patch removes the flag from the default power10 flags, like > you want. However, it doesn't remove it from OTHER_POWER10_MASKS, > since that is used to set ISA_3_1_MASKS_SERVER and I didn't want > to change how rs6000_machine_from_flags() behaves, so instead, I > just explicitly mask it off when defining the power10 default flags.
Historically the reason behind the two methods is they were done by different people in parallel. I had done the mask first in my pc-rel patches, but it took a long time to integrate these into the compiler. Bill Schmidt did the functions as part of another change (rewriting built-ins maybe) But prefixed and pc-rel cannot be added willy-nilly with -mcpu=power10 due to conforming with other parts of the system (assembler, linker, ABIs, etc.). -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com
