On 23/11/2023 12:41, Marek Polacek wrote: > On Mon, Nov 20, 2023 at 05:29:58PM -0500, Jason Merrill wrote: > > On 11/17/23 09:50, Alex Coplan wrote: > > > Hi, > > > > > > This is a v5 patch to address Marek's feedback here: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635157.html > > > > > > I also implemented Jason's suggestion to use constexpr for the tables > > > from this review: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634484.html > > > > > > I'll attach the incremental change in reply to Marek's review to make > > > things easier to compare. > > > > > > Bootstrapped/regtested on aarch64-linux-gnu. Bootstrap/regtest on > > > x86_64-apple-darwin in progress (on top of this libsanitizer fix: > > > https://github.com/llvm/llvm-project/issues/72639). > > > > > > OK for trunk if testing passes? > > > > > --- a/gcc/c-family/c-common.h > > > +/* Implemented in c/c-objc-common.cc. */ > > > +extern void c_register_features (); > > > > I think this declaration should go in c-objc-common.h, though the C > > maintainers might prefer c-lang.h or c-tree.h. > > > > > +/* Implemented in cp/cp-objcp-common.cc. */ > > > +extern void cp_register_features (); > > > > And this one in cp-objc-common.h. > > > > With that change the patch is OK on Friday if Marek doesn't have any other > > notes. > > v5 looks good to me. Thanks,
Many thanks both for the reviews, this is now pushed (with Jason's above changes implemented) as g:06280a906cb3dc80cf5e07cf3335b758848d488d. Alex > > Marek >
