On Wed, May 23, 2012 at 7:58 PM, Nathan Sidwell <nat...@acm.org> wrote: > On 05/22/12 15:12, Richard Guenther wrote: > >> But I wonder why CONSTRUCTORs do not inherit TREE_SIDE_EFFECTS >> properly ... > > > the attached patch fixes the ICE and causes no regressions on > i686-pc-linux-gnu. > > ok?
Looks ok to me. Though I wonder how we got away with that for so long time ... What do others prefer? Keep CONSTRUCTORs "broken" and paper over in gimplify.c instead? If you don't hear from somebody else in 24h the patch is ok as-is (can you do some grepping whether there are callers of build_constructor that set TREE_SIDE_EFFECTS on it afterwards?) Thanks, Richard. > nathan
