Andrew Carlotti <andrew.carlo...@arm.com> writes:

> On Fri, Nov 17, 2023 at 11:45:16AM +0100, Marc Poulhi�s wrote:
>>
>> Hello,
>>
>> > I haven't manged to test the Ada frontend, but this patch (and the 
>> > following
>>
>> I don't have an aarch64 setup to test, but I may be able to help with the
>> issue preventing you from testing. Can you elaborate what is the problem?
>>
>> Marc
>
> I only really got as far as trying to configure a build environemnt, which
> failed with 'configure: error: GNAT is required to build ada'.  I have no 
> prior
> Ada experience, and I couldn't work out how to get any relevant test code to
> compile on Compiler Explorer.  I therefore decided it wasn't worth me spending
> more effort trying to test from Ada a small change to some code that is
> effectively front-end independent, but just happens to be added to a limited
> subset of front ends.
>
> It's probably sufficient to simply test that the Ada changes can be built for
> any target, since I'd be surprised if I've managed to copy this code from C++
> in a way that breaks functionality without obviously breaking the build.

Hello,

I've tested your changes. The compiler builds correctly and there's
no regression (x86_64-linux) + I've also executed some extra tests.

> gcc/ada/ChangeLog:
>       * gcc-interface/utils.cc (attr_noinline_exclusions): New.
>       (attr_always_inline_exclusions): Ditto.
>       (attr_target_exclusions): Ditto.
>       (attr_target_clones_exclusions): Ditto.
>       (gnat_internal_attribute_table): Add new exclusion lists.
>       (handle_noinline_attribute): Remove custom exclusion handling.
>       (handle_target_attribute): Ditto.
>       (handle_target_clones_attribute): Ditto.

Ok.

Marc

Reply via email to