> > +Wsuggest-attribute=returns_nonnull > > - or _? > > (If changing it, needs adjustment in rest of patch too.) I was thinking of this and I am not sure what is better. Sure _ in command line option looks odd, but this is an identifier and it is returns_nonnull and not returns-nonnull.
I am not sure we have earlier situation like that. I can live with both variants and would be happy to hear opinions on this. > > > +Common Var(warn_suggest_attribute_malloc) Warning > > +Warn about functions which might be candidates for __attribute__((malloc)). > > + > > Typo: s/malloc/nonnull/? Thanks! Honza