On May 22, 2012, at 8:42 AM, Jason Merrill wrote: > On 05/22/2012 08:22 AM, Paolo Carlini wrote: >> Ok, thanks. Today I wanted to concretely test and post a patch but I >> noticed this other objc bit in objc-next-runtime-abi-01.c which I don't >> know how to handle due to the OPT_Wall gate: >> >> warning_at (UNKNOWN_LOCATION, OPT_Wall, >> "%<-fobjc-sjlj-exceptions%> is the only supported exceptions " >> "system for %<-fnext-runtime%> with %<-fobjc-abi-version%> < 2"); >> >> If the objc maintainers could help with those uses of warning_at (0 in >> the objc tree, I have a patch ready for the asserts proper. > > What if we just changed UNKNOWN_LOCATION to BUILTINS_LOCATION for these > diagnostics?
I thought about that, but only after wanting to use COMMANDLINE_LOCATION, looking around and not finding it.... If everyone else is using BUILTINS_LOCATION, that's fine, but just seems wrong. UNKNOWN almost seems like a better match at first blush.
