Yes, my finding back then was that this is leftover code from the initial implementation, nothing to do with the rest of the changes. I will first re-evaluate this and test it separately from the other series. If all is good I'll let you know so we can proceed.
Manolis On Sat, Nov 11, 2023 at 12:03 AM Jeff Law <jeffreya...@gmail.com> wrote: > > > > On 8/30/23 04:14, Manolis Tsamis wrote: > > This code used to handle register replacement issues with SUBREG before > > simplify_replace_rtx was introduced. This should not be needed anymore as > > new_val has the correct mode and that should be preserved by > > simplify_replace_rtx. > > > > gcc/ChangeLog: > > > > * ifcvt.cc (noce_convert_multiple_sets_1): Remove old code. > So is it the case that this code is supposed to no longer be needed as a > result of your kit or it is unnecessary independent of patches 1..3? If > the latter then it's OK for the trunk now. > > Jeff
