Hi Yi Xuan: This patch is trivial, and generally LGTM, but I would require putting the spec into https://github.com/riscv-non-isa/riscv-toolchain-conventions before merging this, also don't forget include "RISC-V:" in the title, it would be easier to track during the RISC-V GCC sync meeting :)
And I am a little bit confused by the author's info? is it from you or "XYenChi <oriachi...@gmail.com>"? or oriachi...@gmail.com is also your mail address? cc Christoph since I believe you may know more about that process. cc JoJo since you are T-head folk :P On Wed, Nov 8, 2023 at 9:13 PM <chenyix...@iscas.ac.cn> wrote: > > From: XYenChi <oriachi...@gmail.com> > > This patch is for support xtheadv. > > gcc/ChangeLog: > > 2023-11-08 Chen Yixuan <chenyix...@iscas.an.cn> > > * common/config/riscv/riscv-common.cc: Add xthead minimal support. > > gcc/config/ChangeLog: > > 2023-11-08 Chen Yixuan <chenyix...@iscas.an.cn> > > * riscv/riscv.opt: Add xthead minimal support. > --- > gcc/common/config/riscv/riscv-common.cc | 2 ++ > gcc/config/riscv/riscv.opt | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/gcc/common/config/riscv/riscv-common.cc > b/gcc/common/config/riscv/riscv-common.cc > index 526dbb7603b..d5ea0ee9b70 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -325,6 +325,7 @@ static const struct riscv_ext_version > riscv_ext_version_table[] = > {"xtheadmemidx", ISA_SPEC_CLASS_NONE, 1, 0}, > {"xtheadmempair", ISA_SPEC_CLASS_NONE, 1, 0}, > {"xtheadsync", ISA_SPEC_CLASS_NONE, 1, 0}, > + {"xtheadv", ISA_SPEC_CLASS_NONE, 0, 7}, > > {"xventanacondops", ISA_SPEC_CLASS_NONE, 1, 0}, > > @@ -1680,6 +1681,7 @@ static const riscv_ext_flag_table_t > riscv_ext_flag_table[] = > {"xtheadmemidx", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADMEMIDX}, > {"xtheadmempair", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADMEMPAIR}, > {"xtheadsync", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADSYNC}, > + {"xtheadv", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADV}, > > {"xventanacondops", &gcc_options::x_riscv_xventana_subext, > MASK_XVENTANACONDOPS}, > > diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt > index 70d78151cee..2bbdf680fa2 100644 > --- a/gcc/config/riscv/riscv.opt > +++ b/gcc/config/riscv/riscv.opt > @@ -438,6 +438,8 @@ Mask(XTHEADMEMPAIR) Var(riscv_xthead_subext) > > Mask(XTHEADSYNC) Var(riscv_xthead_subext) > > +Mask(XTHEADV) Var(riscv_xthead_subext) > + > TargetVariable > int riscv_xventana_subext > > -- > 2.42.0 >