Hi Jason, On 26/10/2023 17:06, Jason Merrill wrote: > On 10/25/23 06:28, Alex Coplan wrote: > > On 11/10/2023 14:31, Alex Coplan wrote: > > > On 27/09/2023 15:27, Alex Coplan wrote: > > > > Hi, > > > > > > > > This is a v4 patch to address Jason's feedback here: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630911.html > > > > > > > > w.r.t. v3 it just removes a comment now that some uncertainty around > > > > cxx_binary_literals has been resolved, and updates the documentation as > > > > suggested to point to the Clang docs. > > > > > > > > ---------------------------------------------------------------------- > > Incidentally, putting a 8< or >8 in the line of dashes lets git am > --scissors prune the text above the line. > > > > > This patch implements clang's __has_feature and __has_extension in GCC. > > > > Currently the patch aims to implement all documented features (and some > > > > undocumented ones) following the documentation at > > > > https://clang.llvm.org/docs/LanguageExtensions.html with the exception > > > > of the legacy features for C++ type traits. These are omitted, since as > > > > the clang documentation notes, __has_builtin is the correct "modern" way > > > > to query for these (which GCC already implements). > > > > > > Gentle ping on this: > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631525.html > > > > Ping^2 > > > +static const hf_feature_info has_feature_table[] = > > You might use constexpr for these tables?
I'll give that a go, thanks. > > OK either way, thanks! Thanks a lot for the reviews. Just to clarify, does this OK count for the C front-end parts as well as the C++ and generic parts, or do we need a C front-end maintainer to take a look at those bits? Thanks, Alex > > Jason >
