On 2 November 2023 18:06:54 CET, Maxim Kuvyrkov <maxim.kuvyr...@linaro.org>
wrote:
>> On Nov 2, 2023, at 21:02, rep.dot....@gmail.com wrote:
>>
>> Hi Maxim!
>>
>> Many thanks for the patch! Quick question below..
>>
>> On 2 November 2023 13:48:55 CET, Maxim Kuvyrkov <maxim.kuvyr...@linaro.org>
>> wrote:
>>> ... to restore compatability with validate_failures.py .
>>> The testsuite script validate_failures.py expects
>>> "Running <sub-testsuite> ..." to extract <sub-testsuite> values,
>>> and gotools.sum provided "Running <sub-testsuite>".
>>>
>>> Note that libgo.sum, which also uses Makefile logic to generate
>>> DejaGnu-like output, already has "..." suffix.
>>>
>>> gotools/ChangeLog:
>>>
>>> * Makefile.am: Update "Running <sub-testsuite> ..." output
>>> * Makefile.in: Regenerate.
>>> ---
>>> gotools/Makefile.am | 4 ++--
>>> gotools/Makefile.in | 5 +++--
>>> 2 files changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/gotools/Makefile.am b/gotools/Makefile.am
>>> index 7b5302990f8..d2376b9c25b 100644
>>> --- a/gotools/Makefile.am
>>> +++ b/gotools/Makefile.am
>>> @@ -332,8 +332,8 @@ check: check-head check-go-tool check-runtime
>>> check-cgo-test check-carchive-test
>>> @cp gotools.sum gotools.log
>>> @for file in cmd_go-testlog runtime-testlog cgo-testlog carchive-testlog
>>> cmd_vet-testlog embed-testlog; do \
>>> testname=`echo $${file} | sed -e 's/-testlog//' -e 's|_|/|'`; \
>>> - echo "Running $${testname}" >> gotools.sum; \
>>> - echo "Running $${testname}" >> gotools.log; \
>>> + echo "Running $${testname} ..." >> gotools.sum; \
>>> + echo "Running $${testname} ..." >> gotools.log; \
>>> sed -e 's/^--- \(.*\) ([^)]*)$$/\1/' < $${file} >> gotools.log; \
>>> grep '^--- ' $${file} | sed -e 's/^--- \(.*\) ([^)]*)$$/\1/' -e
>>> 's/SKIP/UNTESTED/' | sort -k 2 >> gotools.sum; \
>>> done
>>> diff --git a/gotools/Makefile.in b/gotools/Makefile.in
>>> index 2783b91ef4b..9cc238e748d 100644
>>> --- a/gotools/Makefile.in
>>> +++ b/gotools/Makefile.in
>>> @@ -317,6 +317,7 @@ pdfdir = @pdfdir@
>>> prefix = @prefix@
>>> program_transform_name = @program_transform_name@
>>> psdir = @psdir@
>>> +runstatedir = @runstatedir@
>>
>> Are you sure you used the correct version of automake?
>
>I used automake 1.15.1 (from Ubuntu 20.04 automake-1.15 package), and I
>double-checked after getting the runstatedir update.
I think that runstatedir is a Debian (and derivatives) addition, would probably
suffice to just drop that line manually..
The patch itself looks like it would be ok, probably even obvious, but I can
not approve it.
I'm a bit surprised that you don't need to have "exp" != None for
validate-failures to work after your exp addition, but I take it you checked
that aspect :-)
thanks, again!
>
>I would appreciate someone checking on their side to make sure I don't have
>something weird going on in my setup.
>
>--
>Maxim Kuvyrkov
>https://www.linaro.org
>
