On Tue, 31 Oct 2023, Robin Dapp wrote: > >> +int > >> +internal_fn_else_index (internal_fn fn) > > > > The function needs a comment, maybe: > > > > /* If FN is an IFN_COND_* or IFN_COND_LEN_* function, return the index of > > the > > argument that is used when the condition is false. Return -1 otherwise. > > */ > > > > OK for the internal-fn* and tree-if-conv.cc bits (which were the > > parts I commented on earlier). I'll look at cleaning up the > > definition of conditional internal functions separately, so that > > the list of functions isn't necessary. > > Thank you, added the comment (shouldn't have forgotten it in the > first place...). So there's the vectorizer part left that is not > yet OK'd.
The vectorizer part is OK. Richard.
