Hi Michael,

> The MICROBLAZE_VERSION_COMPARE was incorrectly using strcasecmp 
> instead of strverscmp to check the mcpu version against feature 
> options.  By simply changing the define to use strverscmp, the new 
> version 10.0 is treated correctly as a higher version than previous 
> versions.
> 
> Signed-off-by: Neal Frager <neal.fra...@amd.com>

> Added to commit message;
>     Fix incorrect warning with -mcpu=10.0:
>       warning: '-mxl-multiply-high' can be used only with
>       '-mcpu=v6.00.a' or greater

> ---
> V1->V2:
>   - No need to create a new microblaze specific version check
>     routine as strverscmp is the correct solution.
> V2->V3:
>   - Changed mcpu define for microblaze isa testsuite examples.
> V3->V4:
>   - Added ChangeLog
> V4->V5:
>   - Added testsuite ChangeLog
> V5->V6:
>   - Updated testsuite ChangeLog to include all files
> ---
>   gcc/ChangeLog                                 |  4 ++++
>   gcc/config/microblaze/microblaze.cc           |  2 +-
>   gcc/testsuite/ChangeLog                       | 22 +++++++++++++++++++
>   .../gcc.target/microblaze/isa/bshift.c        |  2 +-
>   gcc/testsuite/gcc.target/microblaze/isa/div.c |  2 +-
>   .../gcc.target/microblaze/isa/fcmp1.c         |  2 +-
>   .../gcc.target/microblaze/isa/fcmp2.c         |  2 +-
>   .../gcc.target/microblaze/isa/fcmp3.c         |  2 +-
>   .../gcc.target/microblaze/isa/fcmp4.c         |  2 +-
>   .../gcc.target/microblaze/isa/fcvt.c          |  2 +-
>   .../gcc.target/microblaze/isa/float.c         |  2 +-
>   .../gcc.target/microblaze/isa/fsqrt.c         |  2 +-
>   .../microblaze/isa/mul-bshift-pcmp.c          |  2 +-
>   .../gcc.target/microblaze/isa/mul-bshift.c    |  2 +-
>   gcc/testsuite/gcc.target/microblaze/isa/mul.c |  2 +-
>   .../microblaze/isa/mulh-bshift-pcmp.c         |  2 +-
>   .../gcc.target/microblaze/isa/mulh.c          |  2 +-
>   .../gcc.target/microblaze/isa/nofcmp.c        |  2 +-
>   .../gcc.target/microblaze/isa/nofloat.c       |  2 +-
>   .../gcc.target/microblaze/isa/pcmp.c          |  2 +-
>   .../gcc.target/microblaze/isa/vanilla.c       |  2 +-
>   .../gcc.target/microblaze/microblaze.exp      |  2 +-
>   22 files changed, 46 insertions(+), 20 deletions(-)

> Committed.

Did you commit this patch?  I only see the ChangeLog files have been
updated by your commit.

Am I missing something?

Best regards,
Neal Frager
AMD

Reply via email to