Committed, thanks Jeff. Pan
-----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Saturday, October 28, 2023 11:00 PM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang <yanzhang.w...@intel.com>; kito.ch...@gmail.com Subject: Re: [PATCH v1] RISC-V: Fix one range-loop-construct warning of avlprop On 10/28/23 08:51, pan2...@intel.com wrote: > From: Pan Li <pan2...@intel.com> > > This patch would like to fix one warning of avlprop as below. > > ../../gcc/config/riscv/riscv-avlprop.cc: In member function 'virtual > unsigned int pass_avlprop::execute(function*)': > ../../gcc/config/riscv/riscv-avlprop.cc:346:23: error: loop variable > 'candidate' creates a copy from type 'const std::pair<avlprop_type, > rtl_ssa::insn_info*>' [-Werror=range-loop-construct] > 346 | for (const auto candidate : m_candidates) > | ^~~~~~~~~ > ../../gcc/config/riscv/riscv-avlprop.cc:346:23: note: use reference type > to prevent copying > 346 | for (const auto candidate : m_candidates) > | ^~~~~~~~~ > | & > > gcc/ChangeLog: > > * config/riscv/riscv-avlprop.cc (pass_avlprop::execute): Use > reference type to prevent copying. OK jeff >
