On 10/27/23 01:37, juzhe.zh...@rivai.ai wrote:
LGTM from my side.

The original integer division COST seems too low.
Almost certainly, though there may be good reasons why it was initially set so low. I'm generally hesitant to change things like that without either someone with knowledge of the code/uarch stepping in with a recommendation or some kind of analysis showing their wrong.


Hi, Jeff and Kito. Could take a look at this patch ?
It's on the list.

jeff

Reply via email to