On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon <christophe.l...@linaro.org> wrote: > We have noticed that the new tests fail on aarch64 with: > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start': > .../sysdeps/aarch64/start.S:110:(.text+0x38): undefined reference to `main' > > Looking at the test, I'd say it lacks a dg-do compile (to avoid > linking), but how does it work on other targets?
Thanks for pointing it out. I am definitely under the impression that { dg-do compile } is the default and doesn't need to be specified, I have never seen it not be the case before... Is that just not correct? I tried it out on the cfarm (gcc185) for aarch64-redhat-linux and it works for me there too, I tried the test individually and also as part of the whole check-gcc-c++ target. I do see that there are target-dependent functions in testsuite/lib/*.exp that will change dg-do-what-default under some circumstances... but I also see in dg-pch.exp (which is the one relevant for this test g++.dg/pch/pr36887.C) that dg-do-what-default is set to compile explicitly. Note sure what the best next step is, should I just add { dg-do compile } since it's harmless in any case, or is there something else worth looking into here? I'm not sure why I couldn't reproduce the issue on the compile farm machine either, maybe you wouldn't mind please check if adding this line fixes it for you anyway? Thanks... -Lewis