Hi Juzhe,

good that you noticed it now,  I should have caught that
in the review back then...

One thing, though:

> +  if (inner_offsize < GET_MODE_BITSIZE (GET_MODE (ptr)).to_constant ())

Shouldn't ptr always be Pmode i.e. the bitsize == XLEN?

Rest LGTM.

Regards
 Robin

Reply via email to