> From: Christophe Lyon <christophe.l...@linaro.org> > Date: Tue, 3 Oct 2023 15:20:39 +0200
> The patch passed almost all our CI configurations, except arm-eabi when > testing with > -mthumb/-march=armv6s-m/-mtune=cortex-m0/-mfloat-abi=soft/-mfpu=auto > where is causes these failures: > FAIL: 29_atomics/atomic_flag/clear/1.cc -std=gnu++17 (test for excess > errors) > UNRESOLVED: 29_atomics/atomic_flag/clear/1.cc -std=gnu++17 compilation > failed to produce executable > FAIL: 29_atomics/atomic_flag/cons/value_init.cc -std=gnu++20 (test for > excess errors) > UNRESOLVED: 29_atomics/atomic_flag/cons/value_init.cc -std=gnu++20 > compilation failed to produce executable > FAIL: 29_atomics/atomic_flag/cons/value_init.cc -std=gnu++26 (test for > excess errors) > UNRESOLVED: 29_atomics/atomic_flag/cons/value_init.cc -std=gnu++26 > compilation failed to produce executable > FAIL: 29_atomics/atomic_flag/test_and_set/explicit.cc -std=gnu++17 (test > for excess errors) > UNRESOLVED: 29_atomics/atomic_flag/test_and_set/explicit.cc -std=gnu++17 > compilation failed to produce executable > FAIL: 29_atomics/atomic_flag/test_and_set/implicit.cc -std=gnu++17 (test > for excess errors) > UNRESOLVED: 29_atomics/atomic_flag/test_and_set/implicit.cc -std=gnu++17 > compilation failed to produce executable For which set of multilibs in that set, do you get these errors? I'm guessing -march=armv6s-m, but I'm checking. > The linker error is: > undefined reference to `__atomic_test_and_set' I read that as you're saying you have a multilib combination where you currently don't emit __sync_synchronize but also don't emit anything for __atomic_test_and_set. > Maybe we need a new variant of dg-require-thread-fence ? Perhaps. Unless of course, there's a multilib combination for which you *can* emit the proper atomic spell; missing it because the need for it, has been hidden! (At first I thought it was related to caching the thread-fence property across multilib testing, but I don't think that was correct.) > > Thanks, > > Christophe > > > Ok to commit? ENOPATCH brgds, H-P
