The patch works on AIX. I have Gawk installed, but it is a very old release before multi-dimensional array support was added.
Thanks, David On Mon, Oct 2, 2023 at 10:38 PM Kito Cheng <kito.ch...@gmail.com> wrote: > Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix > mode) on my linux also some other report it work on freebsd, just wait > review :) > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html > > On Tue, Oct 3, 2023 at 2:07 AM Jeff Law <jeffreya...@gmail.com> wrote: > > > > > > > > On 10/2/23 12:03, David Edelsohn wrote: > > > On Mon, Oct 2, 2023 at 1:59 PM Jeff Law <jeffreya...@gmail.com > > > <mailto:jeffreya...@gmail.com>> wrote: > > > > > > > > > > > > On 10/2/23 11:20, David Edelsohn wrote: > > > > Wang, > > > > > > > > The AWK portions of this patch broke bootstrap on AIX. > > > > > > > > Also, the AWK portions are common code, not RISC-V specific. I > > > don't > > > > see anywhere that the common portions of the patch were > reviewed or > > > > approved by anyone with authority to approve the changes to the > > > AWK files. > > > > > > > > This patch should not have been committed without approval by a > > > reviewer > > > > with authority for that portion of the compiler and should have > been > > > > tested on targets other than RISC-V if common parts of the > > > compiler were > > > > changed. > > > I acked the generic bits. So the lack of testing on another > target is > > > on me. > > > > > > > > > Hi, Jeff > > > > > > Sorry. I didn't see a comment from a global reviewer in the V3 thread. > > NP. > > > > > > > > I am using Gawk on AIX. After the change, I see a parse error from > > > gawk. I'm rebuilding with a checkout just before the change to confirm > > > that it was the source of the error, and it seems to be past that > > > failure location. I didn't keep the exact error. Once I get past this > > > build cycle, I'll reproduce it. > > I think there's already a patch circulating which fixes this. It broke > > at least one other platform. Hopefully it'll all be sorted out today. > > > > > > jeff >
