On 26 September 2023 23:02:10 CEST, "Andre Vieira (lists)" <andre.simoesdiasvie...@arm.com> wrote: > > >On 26/09/2023 21:26, Bernhard Reutner-Fischer wrote: >> On 26 September 2023 18:46:11 CEST, Tobias Burnus <tob...@codesourcery.com> >> wrote: >>> On 26.09.23 18:37, Andrew Stubbs wrote: >>>> If the fall-through is deliberate please add a /* FALLTHROUGH */ >>>> comment (or whatever spelling disables the warning). >>>
> >I was surprised my bootstrap didn't catch this, I thought we generated >warnings in such cases and bootstrap builds with -Werror does it not? Well, I wouldn't see much benefit to warn in this case, no? You're falling through to a break, not other "active" code AFAICS? You had: references->safe_push (ref); return false; + case IFN_MASK_CALL: + i = 1; default: break; } I would not have expected a warning here, TBH :-) thanks,