On 05/14/2012 08:08 AM, Bernd Schmidt wrote:
On 05/09/2012 05:53 PM, Vladimir Makarov wrote:
It is pretty interesting and original idea. My only major objection to
the patch is about treatment of ALLOCNO_CHEAP_CALLS_CROSSED_NUM. I think
it should be accumulated as ALLOCNO_CALLS_CROSSED_NUM.
Changed (places in ira-buld.c).
I don't expect that this micro-optimization improves SPEC2000, but it
will improve some tests. So it is good to have it. It would be really
interesting to see the optimization impact on SPEC2000. I think I'll do
it for myself in a week.
So IRA part of the patch is ok for me if you modify treatment of
ALLOCNO_CHEAP_CALLS_CROSSED_NUM as it is done for
ALLOCNO_CALLS_CROSSED_NUM (when upper region allocnos accumulate the
values from the corresponding allocnos from its sub-regions).
Ok, that looks like three votes in favour. I've checked in the
following variant with a few minor changes. I've added strcpy and
memset to the list of functions, and split off a new function in
ira-lives.
IRA part is ok for me now. Thanks, Bernd.
