Re: [C++ Patch] PR 44516

[Jason Merrill]

On 05/13/2012 07:25 PM, Paolo Carlini wrote:

You're adding a lot of uses of input_location; I think we can do better.

        if (TREE_CODE (incr) == MODIFY_EXPR)
-       incr = build_x_modify_expr (RECUR (TREE_OPERAND (incr, 0)), NOP_EXPR,
+       incr = build_x_modify_expr (input_location,

EXPR_LOC_OR_HERE (incr), I would think.

        tree r = build_x_modify_expr
-         (RECUR (TREE_OPERAND (t, 0)),
+         (input_location,

And EXPR_LOC_OR_HERE (t).

-                 iter_incr = build_x_modify_expr (iter, TREE_CODE (rhs),
+                 iter_incr = build_x_modify_expr (input_location,
+                                                  iter, TREE_CODE (rhs),
                                                   TREE_OPERAND (rhs, 1),

And EXPR_LOC_OR_HERE (rhs).

And so on.

Jason