On Fri, 8 Sept 2023 at 11:10, Jonathan Wakely <jwakely....@gmail.com> wrote: > > The patch looks good, thanks. I noticed the unconditional -Werror the other > day when testing a build on avr. > > N.B. All patches should go to gcc-patches (as well as a more specific list > like libstdc++ when appropriate). > > OK for trunk
I've pushed this now - thanks again. > > > > On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, > <libstd...@gcc.gnu.org> wrote: >> >> Added to CC: jwak...@redhat.com, h...@axis.com >> >> >> On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote: >> > -Werror flag should depend on --enable-werror configure option >> > >> > --- >> > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +- >> > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +- >> > 2 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am >> > b/libstdc++-v3/src/libbacktrace/Makefile.am >> > index 9abf9dd64a1..27c1ea570e0 100644 >> > --- a/libstdc++-v3/src/libbacktrace/Makefile.am >> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am >> > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \ >> > $(BACKTRACE_CPPFLAGS) >> > >> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ >> > - -Wcast-qual -Werror >> > + -Wcast-qual >> > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes >> > -Wold-style-definition -Wno-unused-but-set-variable >> > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter >> > AM_CFLAGS = $(C_WARN_FLAGS) >> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in >> > b/libstdc++-v3/src/libbacktrace/Makefile.in >> > index 1c1242d8827..b78c8443751 100644 >> > --- a/libstdc++-v3/src/libbacktrace/Makefile.in >> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in >> > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@ >> > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@ >> > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@ >> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ >> > - -Wcast-qual -Werror >> > + -Wcast-qual >> > >> > XMLCATALOG = @XMLCATALOG@ >> > XMLLINT = @XMLLINT@ >>
