On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen <paulbendi...@gmail.com> wrote: > > Hi > Jonathan, I just went over the proposal again as well as [compliance], which > Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention either > <cstdbool> or <cstdalign>.
Those headers were freestanding in C++17. They're not present in C++20 and C++23, but we support C++17 and earlier standards. In GCC 12 <cstdalign> and <cstdbool> were both installed when you built the library with --disable-hosted-libstdcxx, so the fact they're no longer installed for a freestanding build in GC 13 is a regression. Please do include them. > > Shouldn't I just stick to the ones we know are in? > > (Still working on figuring out how to do the change log thing) > > Best regards > Paul > > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen > <paulbendi...@gmail.com>: >> >> Yes, the other files are in another committee proposal, and I'm working my >> way through the proposals one by one. >> Thank you for the feedback, I'll update and resend >> /Paul >> >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <ar...@aarsen.me>: >>> >>> >>> Jonathan Wakely <jwak...@redhat.com> writes: >>> >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >>> > <libstd...@gcc.gnu.org> wrote: >>> >> >>> >> P1642 includes the header cstdarg to the freestanding implementation. >>> >> This was probably left out by accident, this patch puts it in. >>> >> Since this is one of the headers that go in whole cloth, there should be >>> >> no >>> >> further actions needed. >>> > >>> > Thanks for the patch. I agree that <cstdarg> should be freestanding, >>> > but I think <cstdalign> and <cstdbool> were also missed from the >>> > change. Arsen? >>> >>> Indeed, we should include all three, and according to [compliance], >>> there's a couple more headers that we should provide (cwchar, cstring, >>> cerrno, and cmath, but these are probably significantly more involved, >>> so we can handle them separately). >>> >>> As guessed, the omission was not intentional. >>> >>> If you could, add those two to the patch as well, edit Makefile.am and >>> regenerate using automake 1.15.1, and see >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >>> >>> Thank you! Have a lovely day :-) >>> >>> [compliance]: https://eel.is/c++draft/compliance >>> >>> > Also, the patch should change include/Makefile.am as well (the .in >>> > file is autogenerated from that one). >>> > >>> > >>> >> This might be related to PR106953, but since that one touches the partial >>> >> headers I'm not sure >>> >>> The headers mentioned in this PR are provided in freestanding, >>> partially, in 13 already, indeed. >>> >>> >> /Paul M. Bendixen >>> >> >>> >> -- >>> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− >>> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// >>> >>> >>> -- >>> Arsen Arsenović >> >> >> >> -- >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− >> − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− > − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −//
