On 8/11/23 08:29, Tsukasa OI wrote:
On 2023/08/11 23:15, Jeff Law wrote:
Originally, it tested that a two letter extension ('Zb') is accepted by
GCC (because the background of PR 102957 was GCC assumed multi-letter
'Z' extensions are three letters or more).
After rejecting unrecognized extensions, "dg-error" is added **just to
avoid the test failure** and that doesn't look right. Yes, we now don't
have an ICE (like in the original report) but after the PR 102957 fix,
we just accepted it, not rejecting it.
Instead, we have a valid (recognized) two-letter 'Z' extension: 'Zk'. I
think replacing "zb" with "zk" is more correct considering the original
bug report (PR 102957) and its assumption.
cf. <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102957>
Thanks. It still seems to me we want to have two tests here.
I would suggest leaving pr102957.c alone since that tests that we give a
proper error for "zb". Then create a new test that verifies "zk" is
accepted without error.
jeff
