On Mon, 2023-08-28 at 10:21 +0800, Kewen.Lin wrote:
> Hi Carl,
<snip>
> >
> > A testcase is added for the new built-in definitions.
> >
> > gcc/ChangeLog:
> > * config/rs6000/dfp.md: New UNSPEC_DQUAN.
>
> Nit: (UNSPEC_DQUAN): New unspec.
Fixed.
>
<snip>
> > +(define_insn "dfp_dqua_<mode>"
> > + [(set (match_operand:DDTD 0 "gpc_reg_operand" "=d")
> > + (unspec:DDTD [(match_operand:DDTD 1 "gpc_reg_operand" "d")
> > + (match_operand:DDTD 2 "gpc_reg_operand" "d")
> > + (match_operand:SI 3 "const_0_to_3_operand" "n")]
> > + UNSPEC_DQUAN))]
> > + "TARGET_DFP"
> > + "dqua<q> %0,%1,%2,%3"
> > + [(set_attr "type" "dfp")
> > + (set_attr "size" "<bits>")])
> > +
> > +(define_insn "dfp_dqua_i<mode>"
>
> Sorry for nitpicking, but what I suggested previously was
> "dfp_dquai_"
> instead of "dfp_dqua_i", "dquai" matches the according mnemonic so
> it's
> read better, i<mode> expands to "idd" and "itd" that look odd to me.
> Do you agree "dquai" is better? If yes, the changelog and the
> related
> expanders need to be updated as well.
>
> The others look good to me, thanks!
We need to get it right, so don't be sorry for nitpicking. My bad for
not getting it right the first time.
Fixed.
Carl
