> On Thu, Aug 24, 2023 at 3:15 PM Jan Hubicka via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: > > > > Hi, > > this patch extends verifier to check that all probabilities and counts are > > initialized if profile is supposed to be present. This is a bit complicated > > by the posibility that we inline !flag_guess_branch_probability function > > into function with profile defined and in this case we need to stop > > verification. For this reason I added flag to cfg structure tracking this. > > > > Bootstrapped/regtested x86_64-linux, comitted. > > Couldn't we have massaged profile_status to avoid extra full_profile? > Aka add PROFILE_{READ,GUESSED}_PARTIAL?
I am working in direction of removing profile_status. We mostly use it to determine whether profile is reliable (or present at all). This is available locally in profile quality info of profile_count and profile_probability. Most existing tests of that value goes wrong when we inline functions with one profile status to functions with another, so they should be replaced by more local tests. Honza