On Thu, 17 Aug 2023 10:03:04 PDT (-0700), rdapp....@gmail.com wrote:
Indeed all ANYLSF patterns have TARGET_HARD_FLOAT (==f extension) which is incompatible with ZHINX or ZHINXMIN anyway. That should really be fixed separately or at least clarified, maybe I'm missing something.
We've also got the broader issue where these PIC patterns are likely not the way to go long term, they're just papering around some other issues (and are likely why we flip the implicit-relocs behavior implicitly). We should probably fix that at some point, but I don't see any reason to block a fix on a cleanup.
That said, given that folks are poking around in here it's probably worth putting together test cases for the other patterns in there.
Still we can go forward with the patch itself as it improves things independently, so LGTM.
Ya, IMO it's fine to add these given they fix the issue.
Regards Robin
