Hi Lehua, > XPASS: gcc.target/riscv/rvv/autovec/partial/slp-1.c scan-assembler \\tvand > XPASS: gcc.target/riscv/rvv/autovec/partial/slp-1.c scan-assembler \\tvand > XPASS: gcc.target/riscv/rvv/autovec/partial/slp-1.c scan-assembler \\tvand > XPASS: gcc.target/riscv/rvv/autovec/partial/slp-1.c scan-assembler \\tvand
Thanks for checking, I know about those but have other FAILs. Probably due to a recent update or so, need to check. > This is because running a testcase with spike+pk will result in an > ILLEGAL INSTRUCTION error if the vtype registers are not initialized > before executing vmv1r.v instruction. This case fails because of this reason, > so explicitly execute vsetvl early. We are currently discussing with Kito to > constrain this case in psABI and ask the execution environment(pk) to ensure > that vtype is initialized, but not so fast. So when encountering a testcase > that > fails because of this reason, I think use this way to fix it is ok. Hmm, ok so that has nothing to do with the rest of the patch but just happend to be the same test case. So we didn't schedule a vsetvl here because vmv1r doesn't require one but the simulation doesn't initialize vtype before the first vsetvl? If this is the only instance, I guess that's OK, but please add a comment as well. OK with the two comments added. Regards Robin
